[PATCH] libcamera: software_isp: Add a clarification comment to AWB

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Apr 4 19:24:32 CEST 2025


On Fri, Apr 04, 2025 at 04:44:43PM +0100, Kieran Bingham wrote:
> Quoting Milan Zamazal (2025-04-03 13:53:55)
> > The computed AWB gains are applied when constructing LUT tables rather
> > than in awb.cpp itself.  This can look confusing when reading awb.cpp,
> > let's add a clarifying comment.
> > 
> > Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
> 
> I don't object:
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > ---
> >  src/ipa/simple/algorithms/awb.cpp | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp
> > index 55719059..cf567e89 100644
> > --- a/src/ipa/simple/algorithms/awb.cpp
> > +++ b/src/ipa/simple/algorithms/awb.cpp
> > @@ -40,6 +40,7 @@ void Awb::prepare(IPAContext &context,
> >                   [[maybe_unused]] DebayerParams *params)
> >  {
> >         auto &gains = context.activeState.awb.gains;
> > +       /* Just report, the gains are applied in LUT algorithm. */
> >         frameContext.gains.red = gains.r();
> >         frameContext.gains.blue = gains.b();
> >  }

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list