[PATCH v2] meson: Do not automatically build documentation if sphinx-build-3 is found

[Quentin Schulz]

Hi Laurent,

On 4/9/25 11:27 PM, Laurent Pinchart wrote:
> From: Quentin Schulz <quentin.schulz at cherry.de>
> 
> Commit aba567338b25 ("Documentation: Move all dependencies into
> features") did an incomplete migration of the documentation boolean
> option into a documentation feature.
> 
> If sphinx-build-3 binary is found on the host system, the documentation
> is built, regardless of the value of the feature option.
> 
> This makes sure that sphinx-build-3 presence is only checked if the
> documentation feature is not disabled (which is the default, as it's
> "auto" by default).
> 
> This is essential for reproducibility for build systems where
> sphinx-build-3 may or may not be present when libcamera is built, and
> also to declutter the generated package if documentation isn't desired.
> 
> Fixes: aba567338b25 ("Documentation: Move all dependencies into features")
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
[merged both find_program into one]
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Buildroot prints

Program sphinx-build-3 sphinx-build skipped: feature documentation disabled

So this seems to be working fine!

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
Tested-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin