[PATCH 3/3] gstreamer: Add remaining controls

[Nicolas Dufresne]

Le mardi 22 avril 2025 à 17:01 +0100, Kieran Bingham a écrit :
> Quoting Nicolas Dufresne (2025-04-22 16:52:15)
> > Le mardi 22 avril 2025 à 16:25 +0200, Jaslo Ziska a écrit :
> > > Now that read- and write-only controls are supported add the remaining
> > > controls.
> > > 
> > > Signed-off-by: Jaslo Ziska <jaslo at ziska.de>
> > > ---
> > >  utils/codegen/gen-gst-controls.py | 16 +++++++++-------
> > >  1 file changed, 9 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py
> > > index 4ca76049..664e4c41 100755
> > > --- a/utils/codegen/gen-gst-controls.py
> > > +++ b/utils/codegen/gen-gst-controls.py
> > > @@ -19,13 +19,15 @@ from controls import Control
> > >  
> > >  
> > >  exposed_controls = [
> > > -    'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',
> > > -    'ExposureValue', 'ExposureTime', 'ExposureTimeMode',
> > > -    'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',
> > > -    'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',
> > > -    'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',
> > > -    'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',
> > > -    'LensPosition', 'Gamma',
> > > +    'AeEnable', 'AeState', 'AeMeteringMode', 'AeConstraintMode',
> > > +    'AeExposureMode', 'ExposureValue', 'ExposureTime', 'AnalogueGain',
> > > +    'AnalogueGainMode', 'AeFlickerMode', 'AeFlickerPeriod',
> > > +    'AeFlickerDetected', 'Brightness', 'Contrast', 'Lux', 'AwbEnable',
> > > +    'AwbMode', 'AwbLocked', 'ColourGains', 'ColourTemperature', 'Saturation',
> > > +    'SensorBlackLevels', 'Sharpness', 'FocusFoM', 'ColourCorrectionMatrix',
> > > +    'ScalerCrop', 'DigitalGain', 'SensorTemperature', 'AfMode', 'AfRange',
> > > +    'AfSpeed', 'AfMetering', 'AfWindows', 'LensPosition', 'AfState',
> > > +    'AfPauseState', 'HdrMode', 'HdrChannel', 'Gamma',
> > 
> > Can we ditch the formater and just make one vertical row ? That would
> > make the diff useful. If not, the list of added controls should be in
> > the description.
> 
> Yes please on this! This would be far more consumable as a straight
> list!
> 
> Bonus points for alphabetical ordering ;-)

Just in case you aren't familiar, we usually make a reformatting patch,
documented as "No functional changes." The next patch adds the entry.

Nicolas

> 
> > 
> > Nicolas
> > 
> > >  ]
> > >  
> > >