[PATCH 0/1] Allow algorithms to be disabled via the tuning file

[Kieran Bingham]

Quoting Laurent Pinchart (2025-04-30 09:31:51)
> Hi Isaac,
> 
> On Tue, Apr 29, 2025 at 01:48:05PM +0100, Isaac Scott wrote:
> > In many use cases, including debugging, it would be useful to disable
> > individual algorithms to ensure the effects of one algorithm are not
> > affecting others. This patch adds this functionality by allowing users
> > to mark algorithms as "disabled" in their camera sensor's tuning file.
> 
> Why do we need this, when we can simply comment them out ?

There can be /many/ lines to comment out for a single algorithm.

https://git.libcamera.org/libcamera/libcamera.git/tree/src/ipa/rkisp1/data/ov8858.yaml#n8
for instance ...

Or for developing/testing - add a single 'disable:' statement - and you
can toggle it quickly. You can even comment out the single disable line
to re-enable it without modifying other lines...

The upstream tuning files we have for libipa are quite simple - but they
can grow substantially once we start adding noise reduction, DPC, or
dewarp parameters for instance.

Not libipa, but trying to comment out AWB from this tuning file for
instance would be quite cumbersome:

 https://git.libcamera.org/libcamera/libcamera.git/tree/src/ipa/rpi/vc4/data/imx219.json#n42

 
> > Isaac Scott (1):
> >   libipa: Allow disabling algorithms via the tuning file
> > 
> >  src/ipa/libipa/module.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> -- 
> Regards,
> 
> Laurent Pinchart