[PATCH v7 07/15] config: Look up rpi config path in configuration file
Milan Zamazal
mzamazal at redhat.com
Thu Feb 6 17:15:58 CET 2025
Let's introduce a configuration option for rpi configuration file path.
It may be arguable whether pipeline specific configurations belong to
the global configuration file. But:
- Having a single configuration file is generally easier for the user.
- The original configuration via environment variables can be already
considered global.
- This option points to other configuration files and it makes little
sense to add another configuration file to the chain.
The configuration snippet:
configuration:
pipeline:
rpi:
config_file: FILENAME
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
---
src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp
index 1f13e523..739dc61a 100644
--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp
+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp
@@ -20,6 +20,7 @@
#include <libcamera/property_ids.h>
#include "libcamera/internal/camera_lens.h"
+#include "libcamera/internal/global_configuration.h"
#include "libcamera/internal/ipa_manager.h"
#include "libcamera/internal/v4l2_subdevice.h"
@@ -1102,7 +1103,12 @@ int CameraData::loadPipelineConfiguration()
/* Initial configuration of the platform, in case no config file is present */
platformPipelineConfigure({});
- char const *configFromEnv = utils::secure_getenv("LIBCAMERA_RPI_CONFIG_FILE");
+ std::optional<std::string> configFile =
+ GlobalConfiguration::envOption("LIBCAMERA_RPI_CONFIG_FILE",
+ "pipelines.rpi.config_file");
+ if (!configFile.has_value())
+ return 0;
+ char const *configFromEnv = configFile.value().c_str();
if (!configFromEnv || *configFromEnv == '\0')
return 0;
--
2.48.1
More information about the libcamera-devel
mailing list