[PATCH 1/1] gstreamer: Fix scaler-crop property get

[Nerijus Bendžiūnas]

Hello,

I'm fine with your suggestion to reuse the cover later as message.

On Sun, Feb 16, 2025 at 7:45 PM Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> Hi Nerijus,
>
> Thank you for the patch, and welcome to libcamera.
>
> On Sun, Feb 16, 2025 at 09:21:31AM +0200, Nerijus Bendžiūnas wrote:
>
> A commit message would be nice. The explanation you provided in the
> cover letter would be a good fit:
>
> Fix a copy/paste/replace typo. Without this fix, the last element (4th)
> is always zero.
>
> > Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas at gmail.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> If you're fine with the updated commit message there's no need to
> resend, I can update the patch when applying.
>
> > ---
> >  src/gstreamer/gstlibcamera-controls.cpp.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/gstreamer/gstlibcamera-controls.cpp.in b/src/gstreamer/
> gstlibcamera-controls.cpp.in
> > index ace36b71..d937b19e 100644
> > --- a/src/gstreamer/gstlibcamera-controls.cpp.in
> > +++ b/src/gstreamer/gstlibcamera-controls.cpp.in
> > @@ -39,7 +39,7 @@ static void value_set_rectangle(GValue *value, const
> Rectangle &rect)
> >
> >       GValue height = G_VALUE_INIT;
> >       g_value_init(&height, G_TYPE_INT);
> > -     g_value_set_int(&x, size.height);
> > +     g_value_set_int(&height, size.height);
> >       gst_value_array_append_and_take_value(value, &height);
> >  }
> >
>
> --
> Regards,
>
> Laurent Pinchart
>


-- 
Nerijus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20250217/0d9fc189/attachment.htm>