[PATCH v3 1/2] libcamera: v4l2_device: add frame start event helpers

[Stanislaw Gruszka]

Hi Laurent,

On Wed, Feb 19, 2025 at 02:35:07PM +0200, Laurent Pinchart wrote:
> > > +       bool frameStartEnabled() { return frameStartEnabled_; }
> 
> The function should be const.
Right. 

> > > +bool V4L2Device::supportsFrameStartEvent()
> > > +{
> > > +       struct v4l2_event_subscription event {
> > > +       };
> > > +       event.type = V4L2_EVENT_FRAME_SYNC;
> > > +
> > > +       int ret = ioctl(VIDIOC_SUBSCRIBE_EVENT, &event);
> > > +       if (ret == 0)
> > > +               ioctl(VIDIOC_UNSUBSCRIBE_EVENT, &event);
> > > +
> > > +       return ret == 0;
> 
> I think the following would be a bit more readable.
> 
>  	int ret = ioctl(VIDIOC_SUBSCRIBE_EVENT, &event);
> 	if (ret)
> 		return false;
> 
> 	ioctl(VIDIOC_UNSUBSCRIBE_EVENT, &event);
> 	return true;

Fine, will recode this way in next version of the patches.

Regards
Stanislaw