[RFC PATCH 3/7] pipeline: rkisp1: Include frame number when pushing to delayed controls

Paul Elder paul.elder at ideasonboard.com
Thu Feb 20 09:49:10 CET 2025


On Fri, Dec 20, 2024 at 05:26:49PM +0100, Stefan Klug wrote:

Missing message... (but otherwise the code and the title are good)


Paul

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 35c793da9bba..71a07c6027b9 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -428,10 +428,10 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused
>  		selfPath_->queueBuffer(info->selfPathBuffer);
>  }
>  
> -void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,
> +void RkISP1CameraData::setSensorControls(unsigned int frame,
>  					 const ControlList &sensorControls)
>  {
> -	delayedCtrls_->push(sensorControls);
> +	delayedCtrls_->push(frame, sensorControls);
>  }
>  
>  void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)
> -- 
> 2.43.0
> 


More information about the libcamera-devel mailing list