[PATCH 14/15] ipa: rkisp1: awb: Capitalize AWB

Stefan Klug stefan.klug at ideasonboard.com
Mon Feb 24 10:41:29 CET 2025


Hi Laurent,

Thank you for the patch. 

On Mon, Feb 24, 2025 at 01:04:02AM +0200, Laurent Pinchart wrote:
> AWB is an abbreviation, capitalize it in comments and log messages for
> consistency.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com> 

> ---
>  src/ipa/rkisp1/algorithms/awb.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp
> index 7f333ef86518..3c2864fd181c 100644
> --- a/src/ipa/rkisp1/algorithms/awb.cpp
> +++ b/src/ipa/rkisp1/algorithms/awb.cpp
> @@ -92,7 +92,7 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)
>  							 kDefaultColourTemperature);
>  
>  	if (!tuningData.contains("algorithm"))
> -		LOG(RkISP1Awb, Info) << "No awb algorithm specified."
> +		LOG(RkISP1Awb, Info) << "No AWB algorithm specified."
>  				     << " Default to grey world";
>  
>  	auto mode = tuningData["algorithm"].get<std::string>("grey");
> @@ -101,14 +101,14 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)
>  	} else if (mode == "bayes") {
>  		awbAlgo_ = std::make_unique<AwbBayes>();
>  	} else {
> -		LOG(RkISP1Awb, Error) << "Unknown awb algorithm: " << mode;
> +		LOG(RkISP1Awb, Error) << "Unknown AWB algorithm: " << mode;
>  		return -EINVAL;
>  	}
> -	LOG(RkISP1Awb, Debug) << "Using awb algorithm: " << mode;
> +	LOG(RkISP1Awb, Debug) << "Using AWB algorithm: " << mode;
>  
>  	int ret = awbAlgo_->init(tuningData);
>  	if (ret) {
> -		LOG(RkISP1Awb, Error) << "Failed to init awb algorithm";
> +		LOG(RkISP1Awb, Error) << "Failed to init AWB algorithm";
>  		return ret;
>  	}
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 


More information about the libcamera-devel mailing list