[PATCH v3 0/6] Fix occasional software ISP assertion error on stop

[Milan Zamazal]

Hi Stanislaw,

Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com> writes:

> Hi Milan,
>
> On Tue, Feb 25, 2025 at 04:06:06PM +0100, Milan Zamazal wrote:
>> When software ISP is stopped, there can be pending messages in the
>> message queue that will attempt to call the already stopped IPA,
>> resulting in an assertion error like this:
>> 
>>   FATAL default soft_ipa_proxy.cpp:456 assertion "state_ == ProxyRunning" failed in processStatsThread()
>> 
>> This patch series fixes the problem and also attempts to prevent other
>> problems related to message handling when or after software ISP is
>> stopped.
>
>> Changes in v3:
>> - Missing <deque> include added.
>> - I/O buffers are popped from the deque’s of queued buffers rather than
>>   searched there + assertion to check it’s the intended buffer added.
>> - Returned pending input buffers are canceled.
>> - The thread.cpp formatting patch dropped.
>> - The dispatching modifications patch split to several patches as
>>   suggested by Laurent.
>> - Thread::removeMessages() documentation improved as suggested by
>>   Laurent.
>> - SoftwareIsp::running_ dropped in the patch adding explicit SoftwareIsp
>>   messages removal.
>> - Formatting fixes suggested by Laurent.
>
>
> Tested with:
> [PATCH] libcamera: delayed_controls: Inherit from Object class
>
> The assertion is fixed and I do not see any other issues with
> the set.
>
> For the series:
> Tested-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>

Good news, thank you for testing.

> Regards
> Stanislaw