[PATCH v3 2/2] pipeline: simple: Use proper device for frame start events

[Stanislaw Gruszka]

Hi Bingbu,

On Tue, Feb 25, 2025 at 02:05:38PM +0800, Bingbu Cao wrote:
> 
> On 2/25/25 5:14 AM, Laurent Pinchart wrote:
> > (CC'ing Bingbu)
> > 
> > On Mon, Feb 24, 2025 at 02:29:52PM +0100, Stanislaw Gruszka wrote:
> >> On Mon, Feb 24, 2025 at 02:24:12PM +0200, Laurent Pinchart wrote:
> >>> On Mon, Feb 24, 2025 at 12:02:30PM +0100, Stanislaw Gruszka wrote:
> >>>>
> >>>>> I expect CSI-2 errors to be extremely rare. Did you actually get some ?
> >>>>> Or were frames dropped by the driver due to buffer queue underruns ?
> >>>>
> >>>> It's quite good reproducible for IPU6 when first start using camera
> >>>> after boot.
> >>>>
> >>>> [   82.758542] intel_ipu6_isys.isys intel_ipu6.isys.40: csi2-1 error: Payload checksum (CRC) error
> >>>> [   83.250939] intel_ipu6_isys.isys intel_ipu6.isys.40: csi2-1 error: Single packet header error corrected
> >>>> [   83.250962] intel_ipu6_isys.isys intel_ipu6.isys.40: csi2-1 error: Multiple packet header errors detected
> >>>> [   83.250964] intel_ipu6_isys.isys intel_ipu6.isys.40: csi2-1 error: Payload checksum (CRC) error
> >>>> [   83.250965] intel_ipu6_isys.isys intel_ipu6.isys.40: csi2-1 error: Incomplete long packet detected
> >>>> [   83.250966] intel_ipu6_isys.isys intel_ipu6.isys.40: csi2-1 error: Frame sync error
> >>>> [   83.250967] intel_ipu6_isys.isys intel_ipu6.isys.40: csi2-1 error: Inter-frame long packet discarded
> >>>>
> >>>> Not really sure why. After initial errors, things get to
> >>>> work and no other cis2 errors happen.
> >>>
> >>> And that's only the first time after boot ? That sounds like a driver
> >>> bug. What happens if you unload and reload the driver, does the first
> >>> capture session after reloading exhibit the same problems ?
> >>
> >> Reloading intel-ipu6-isys does not exhibit the problem.
> >> However reloading the sensor driver ov2740 does.
> >> Is sufficient to reload ov2740 module and start the qcam
> >> to get those csi2-1 errors.
> > 
> > Bingbu, Sakari, this sounds like a bug in a driver somewhere.
> >
> 
> Stanislaw,
> 
> Which device are you using? I can try it if I have such device.

Lenovo X1 ThinkPad Yoga and Nano.

> Have you a chance to check whether you can reproduce same problem with
> other camera sensors (or other devices)?
>
> In my experience, such errors report likely caused by bad frames from
> sensor in corner case.

FWICT the issue happens only with ov2740 on Lenovo laptops.
I did not recall having those errors on Dell laptops with
different sensors and iVSC, which I also used with ipu6-isys.

Regards
Stanislaw