[PATCH] libcamera: include: Include missing stdint.h header
Kieran Bingham
kieran.bingham at ideasonboard.com
Thu Jan 9 10:42:10 CET 2025
Quoting Laurent Pinchart (2025-01-09 01:45:06)
> Many libcamera headers that use standard C integer types do not include
> stdint.h. Fix the omission.
>
I still wonder how we can get IWYU https://include-what-you-use.org/
into the ci loop sometime.
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> include/libcamera/base/utils.h | 1 +
> include/libcamera/internal/camera.h | 1 +
> include/libcamera/internal/camera_lens.h | 1 +
> include/libcamera/internal/camera_sensor.h | 1 +
> include/libcamera/internal/framebuffer.h | 1 +
> include/libcamera/internal/ipa_data_serializer.h | 1 +
> include/libcamera/internal/ipc_pipe.h | 1 +
> include/libcamera/internal/ipc_pipe_unixsocket.h | 1 +
> include/libcamera/internal/request.h | 1 +
> include/libcamera/internal/tracepoints/request.tp | 2 ++
> include/libcamera/internal/v4l2_device.h | 1 +
> include/libcamera/internal/v4l2_subdevice.h | 1 +
> 12 files changed, 13 insertions(+)
>
> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h
> index 780aeda6a0ce732a..8d5c35782ee34e24 100644
> --- a/include/libcamera/base/utils.h
> +++ b/include/libcamera/base/utils.h
> @@ -13,6 +13,7 @@
> #include <iterator>
> #include <ostream>
> #include <sstream>
> +#include <stdint.h>
> #include <string.h>
> #include <string>
> #include <sys/time.h>
> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h
> index 2bb00bbcb6442b36..18f5c32a18e4def7 100644
> --- a/include/libcamera/internal/camera.h
> +++ b/include/libcamera/internal/camera.h
> @@ -11,6 +11,7 @@
> #include <list>
> #include <memory>
> #include <set>
> +#include <stdint.h>
> #include <string>
>
> #include <libcamera/base/class.h>
> diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h
> index 5a4b993bb2dbcb3e..f347c5e0a5f3078f 100644
> --- a/include/libcamera/internal/camera_lens.h
> +++ b/include/libcamera/internal/camera_lens.h
> @@ -7,6 +7,7 @@
> #pragma once
>
> #include <memory>
> +#include <stdint.h>
> #include <string>
>
> #include <libcamera/base/class.h>
> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h
> index f6002c5f56448faa..13048f327bf2f626 100644
> --- a/include/libcamera/internal/camera_sensor.h
> +++ b/include/libcamera/internal/camera_sensor.h
> @@ -8,6 +8,7 @@
> #pragma once
>
> #include <memory>
> +#include <stdint.h>
> #include <string>
> #include <variant>
> #include <vector>
> diff --git a/include/libcamera/internal/framebuffer.h b/include/libcamera/internal/framebuffer.h
> index e6698a459432812b..97b49d42063f627b 100644
> --- a/include/libcamera/internal/framebuffer.h
> +++ b/include/libcamera/internal/framebuffer.h
> @@ -8,6 +8,7 @@
> #pragma once
>
> #include <memory>
> +#include <stdint.h>
> #include <utility>
>
> #include <libcamera/base/class.h>
> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h
> index 66d9a19fcc54509d..b4614f21d701db0d 100644
> --- a/include/libcamera/internal/ipa_data_serializer.h
> +++ b/include/libcamera/internal/ipa_data_serializer.h
> @@ -7,6 +7,7 @@
>
> #pragma once
>
> +#include <stdint.h>
> #include <string.h>
> #include <tuple>
> #include <type_traits>
> diff --git a/include/libcamera/internal/ipc_pipe.h b/include/libcamera/internal/ipc_pipe.h
> index a45607529cbf8a8e..418c4622ff82ba6d 100644
> --- a/include/libcamera/internal/ipc_pipe.h
> +++ b/include/libcamera/internal/ipc_pipe.h
> @@ -7,6 +7,7 @@
>
> #pragma once
>
> +#include <stdint.h>
> #include <vector>
>
> #include <libcamera/base/shared_fd.h>
> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h
> index 8c972613f314d5b1..845128096280a57a 100644
> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h
> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h
> @@ -9,6 +9,7 @@
>
> #include <map>
> #include <memory>
> +#include <stdint.h>
>
> #include "libcamera/internal/ipc_pipe.h"
> #include "libcamera/internal/ipc_unixsocket.h"
> diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h
> index 4e7d05b1e028079d..73e9bb5ccb0a2941 100644
> --- a/include/libcamera/internal/request.h
> +++ b/include/libcamera/internal/request.h
> @@ -10,6 +10,7 @@
> #include <chrono>
> #include <map>
> #include <memory>
> +#include <stdint.h>
> #include <unordered_set>
>
> #include <libcamera/base/event_notifier.h>
> diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp
> index 4f367e91458be267..42c596850e80dab9 100644
> --- a/include/libcamera/internal/tracepoints/request.tp
> +++ b/include/libcamera/internal/tracepoints/request.tp
> @@ -5,6 +5,8 @@
> * request.tp - Tracepoints for the request object
> */
>
> +#include <stdint.h>
> +
> #include <libcamera/framebuffer.h>
>
> #include "libcamera/internal/request.h"
> diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h
> index f5aa502482017325..affe52c2ad3ff7df 100644
> --- a/include/libcamera/internal/v4l2_device.h
> +++ b/include/libcamera/internal/v4l2_device.h
> @@ -10,6 +10,7 @@
> #include <map>
> #include <memory>
> #include <optional>
> +#include <stdint.h>
> #include <vector>
>
> #include <linux/videodev2.h>
> diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h
> index 194382f84d97fbbc..fa2a4a21eefbb792 100644
> --- a/include/libcamera/internal/v4l2_subdevice.h
> +++ b/include/libcamera/internal/v4l2_subdevice.h
> @@ -10,6 +10,7 @@
> #include <memory>
> #include <optional>
> #include <ostream>
> +#include <stdint.h>
> #include <string>
> #include <vector>
>
>
> base-commit: 340bb7aa63d18516bcb1d21a1b7f10ba039903cf
> --
> Regards,
>
> Laurent Pinchart
>
More information about the libcamera-devel
mailing list