[PATCH v3 7/9] libcamera: software_isp: Add an example CCM to uncalibrated.yaml

[Kieran Bingham]

Quoting Milan Zamazal (2024-12-10 15:34:37)
> For performance reasons, color correction matrix (CCM) is not applied by
> default in software ISP.  But let's add a commented out example how to
> define it to the default tuning file.
> 
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
> ---
>  src/ipa/simple/data/uncalibrated.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml
> index 3f147112..8df3cd4e 100644
> --- a/src/ipa/simple/data/uncalibrated.yaml
> +++ b/src/ipa/simple/data/uncalibrated.yaml
> @@ -5,6 +5,13 @@ version: 1
>  algorithms:
>    - BlackLevel:
>    - Awb:
> +  # Color correction matrices can be defined here:
> +  # - Ccm:
> +  #     ccms:
> +  #       - ct: 6500
> +  #         ccm: [ 1, 0, 0,
> +  #                0, 1, 0,
> +  #                0, 0, 1]

Can't really 'review' that - it's only adding a comment, but I can say
this ;-)


Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

That said - should the example show multiple ccms ? but that doesn't
matter too much - it would be expected to be written by the tuning tool.

so maybe this isn't "needed" but I can see a benefit to having it for
development purposes for now ?

So - I'm not sure if we should apply this patch or not - but it's
definitely useful in case someone is trying to play around with ccm for
the short term.


>    - Lut:
>    - Agc:
>  ...
> -- 
> 2.44.2
>