[PATCH v7 11/12] ipa: rkisp1: agc: Report new AeEnable control as available

Paul Elder paul.elder at ideasonboard.com
Sat Jan 11 00:57:36 CET 2025


Even though the new AeEnable control internally switches on and off the
sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to
be declared as available. Report this control as available in the
rkisp1 IPA.

Support for the control does not need to be added as it is handled by
the Camera class. It does not need to be handled in metadata either as
the new version of AeEnable is not returned in metadata.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

---
No change in v7

New in v6
---
 src/ipa/rkisp1/algorithms/agc.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
index 78122a1f0..ff9a96a43 100644
--- a/src/ipa/rkisp1/algorithms/agc.cpp
+++ b/src/ipa/rkisp1/algorithms/agc.cpp
@@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)
 		ControlInfo(static_cast<int32_t>(controls::AnalogueGainModeAuto),
 			    static_cast<int32_t>(controls::AnalogueGainModeManual),
 			    static_cast<int32_t>(controls::AnalogueGainModeAuto));
+	/* \todo Move this to the Camera class */
+	context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true);
 	context.ctrlMap.merge(controls());
 
 	return 0;
-- 
2.39.2



More information about the libcamera-devel mailing list