[PATCH v1 11/11] ipa: rkisp1: awb: Apply gains based on default colour temperature on start

Paul Elder paul.elder at ideasonboard.com
Tue Jan 14 01:10:57 CET 2025


On Thu, Jan 09, 2025 at 12:54:02PM +0100, Stefan Klug wrote:
> The colour gains are initialized with a default value of 1. Improve that
> by querying the auto white balance algorithm for the gains for a default
> colour temperature. This is still not based on measurements, but it is
> still better than the current implementation. If the algorithm doesn't
> implement mapping from colour temperature to gains, it will internally
> fallback to 1.0.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  src/ipa/rkisp1/algorithms/awb.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp
> index 39a2c0589943..1761185b1181 100644
> --- a/src/ipa/rkisp1/algorithms/awb.cpp
> +++ b/src/ipa/rkisp1/algorithms/awb.cpp
> @@ -125,7 +125,8 @@ int Awb::configure(IPAContext &context,
>  		   const IPACameraSensorInfo &configInfo)
>  {
>  	context.activeState.awb.gains.manual = RGB<double>{ 1.0 };
> -	context.activeState.awb.gains.automatic = RGB<double>{ 1.0 };
> +	context.activeState.awb.gains.automatic =
> +		awbAlgo_->gainsFromColourTemperature(kDefaultColourTemperature);
>  	context.activeState.awb.autoEnabled = true;
>  	context.activeState.awb.temperatureK = kDefaultColourTemperature;
>  
> -- 
> 2.43.0
> 


More information about the libcamera-devel mailing list