[RFC PATCH v2 0/9] libcamera: base: log: Misc. changes

Barnabás Pőcze pobrn at protonmail.com
Thu Jan 30 20:58:14 CET 2025


A collection of misc. changes I made while I was looking
at https://bugs.libcamera.org/show_bug.cgi?id=243 .

Changes in v2:
  * remove `LogMessage` move constructor
  * split function moving into separate patch
  * do not pass the default value of 10 to `std::from_chars()`
  * store `LogCategory`s in `std::list` instead of vector
    of owning raw pointers

v1: https://patchwork.libcamera.org/project/libcamera/list/?series=4960

Barnabás Pőcze (9):
  libcamera: base: log: Remove move constructor
  libcamera: base: log: Use `std::from_chars()`
  libcamera: base: log: Remove `LogMessage::init()`
  libcamera: base: log: Make `LogCategory::severity_` atomic
  libcamera: base: log: Use `std::string_view` to avoid some copies
  libcamera: base: log: Pass dynamic prefix through
  libcamera: base: log: Split `parseLogLevel[s]()`
  libcamera: base: log: Protect log categories with lock
  libcamera: base: log: Store categories in list

 include/libcamera/base/log.h |  22 +--
 src/libcamera/base/log.cpp   | 292 +++++++++++++++--------------------
 2 files changed, 133 insertions(+), 181 deletions(-)

--
2.48.1



More information about the libcamera-devel mailing list