[PATCH 2/2] pipeline: imx8-isi: Fix match returned value in error case

Antoine Bouyer antoine.bouyer at nxp.com
Wed Jun 4 15:14:03 CEST 2025


Match callback returns boolean type, while it could return int in case
of error when opening the capture file.
Fixes: 0ec982d2108 ("libcamera: pipeline: Add IMX8 ISI pipeline")

Signed-off-by: Antoine Bouyer <antoine.bouyer at nxp.com>
---
 src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
index dc20ab2..1b7c661 100644
--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
@@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)
 
 		ret = capture->open();
 		if (ret)
-			return ret;
+			return false;
 
 		pipes_.push_back({ std::move(isi), std::move(capture) });
 	}
-- 
2.34.1



More information about the libcamera-devel mailing list