[PATCH 2/2] pipeline: imx8-isi: Fix match returned value in error case

[Laurent Pinchart]

Hi Antoine,

Thank you for the patch.

On Wed, Jun 04, 2025 at 03:14:03PM +0200, Antoine Bouyer wrote:
> Match callback returns boolean type, while it could return int in case

"The match() function returns a boolean type, ..."

> of error when opening the capture file.

Missing blank line.

> Fixes: 0ec982d2108 ("libcamera: pipeline: Add IMX8 ISI pipeline")
> 

No blank line here.

> Signed-off-by: Antoine Bouyer <antoine.bouyer at nxp.com>

No need to resubmit this patch either.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> index dc20ab2..1b7c661 100644
> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)
>  
>  		ret = capture->open();
>  		if (ret)
> -			return ret;
> +			return false;
>  
>  		pipes_.push_back({ std::move(isi), std::move(capture) });
>  	}

-- 
Regards,

Laurent Pinchart