[PATCH] libcamera: camera: Log info message to report camera creation
adam at piggz.co.uk
adam at piggz.co.uk
Sun Mar 2 21:35:18 CET 2025
I have tested this with the uvcvideo handler and it worked as expected.
Tested-by: Adam Pigg <adam at piggz.co.uk>
On Wednesday, 26 February 2025 00:55:47 Greenwich Mean Time Laurent Pinchart
wrote:
> Camera creation is one of the most important events generated by
> libcamera, but we are completely silent about it. The lack of a log
> message makes it more difficult to identify problems and provide
> support. Fix it by adding an Info message that reports the camera id and
> its pipeline handler when the camera is created.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
> src/libcamera/camera.cpp | 4 ++++
> 1 file changed, 4 insertions(+)
>
>
> base-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3
> --
> Regards,
>
> Laurent Pinchart
>
> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp
> index 56c5851993c9..35097bfdafa2 100644
> --- a/src/libcamera/camera.cpp
> +++ b/src/libcamera/camera.cpp
> @@ -862,6 +862,10 @@ std::shared_ptr<Camera>
> Camera::create(std::unique_ptr<Private> d, }
> };
>
> + LOG(Camera, Info)
> + << "Creating camera '" << id << "' for pipeline handler
"
> + << d->pipe_->name();
> +
> Camera *camera = new Camera(std::move(d), id, streams);
>
> return std::shared_ptr<Camera>(camera, Deleter());
More information about the libcamera-devel
mailing list