[PATCH v5 1/5] libcamera: v4l2_device: add frame start event helpers
Stanislaw Gruszka
stanislaw.gruszka at linux.intel.com
Mon Mar 3 15:08:30 CET 2025
On Mon, Mar 03, 2025 at 12:48:28PM +0000, Kieran Bingham wrote:
> Quoting Stanislaw Gruszka (2025-03-03 10:26:38)
> > Hi Kieran,
> >
> > On Sat, Mar 01, 2025 at 11:17:32PM +0000, Kieran Bingham wrote:
> > > Quoting Stanislaw Gruszka (2025-02-25 16:41:12)
> > > >
> > > > +/**
> > > > + * \brief Check if frame start event is supported
> > > > + * \return True if frame start event is supported, false otherwise
> > > > + */
> > > > +
> > > > +bool V4L2Device::supportsFrameStartEvent()
> > > > +{
> > > > + struct v4l2_event_subscription event {
> > > > + };
> > >
> > > Curiously my local clang-format is trying to make this one line, but the
> > > CI doesn't report anything here.
> > >
> > > So I'll leave it as it is ;-)
> > >
> > > Aha, and I've already got a tag on here so ... to the next one.
> >
> > Does it mean you have a clang-format-ignore file ?
>
> I'm not sure I understand the question. But no - I don't have an
> 'ignore' file on my laptop. Or do you mean one in my head that I can
> ignore things ;-)
:-) I misunderstood your previous comment.
I thought you wrote about clang-format tag that makes auto-formatter
ignore particular file or lines, but you meant Reviewed-by tag :-)
Anyway, this is clang-format version problem as pointed by Barnabás
and Milan. I'll update the patch with:
struct v4l2_event_subscription event {};
since newer clang-format formats this way.
Regards
Stanislaw
More information about the libcamera-devel
mailing list