[PATCH v1] libcamera: base: mutex: Remove unnecessary constructors
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Mar 3 21:59:56 CET 2025
Hi Barnabás,
Thank you for the patch.
On Mon, Mar 03, 2025 at 08:33:30PM +0100, Barnabás Pőcze wrote:
> The compiler defined default constructor works perfectly fine.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> include/libcamera/base/mutex.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/libcamera/base/mutex.h b/include/libcamera/base/mutex.h
> index fa9a8d0dc..20ebe6fee 100644
> --- a/include/libcamera/base/mutex.h
> +++ b/include/libcamera/base/mutex.h
> @@ -23,10 +23,6 @@ namespace libcamera {
> class LIBCAMERA_TSA_CAPABILITY("mutex") Mutex final
> {
> public:
> - constexpr Mutex()
> - {
> - }
> -
> void lock() LIBCAMERA_TSA_ACQUIRE()
> {
> mutex_.lock();
> @@ -84,10 +80,6 @@ private:
> class ConditionVariable final
> {
> public:
> - ConditionVariable()
> - {
> - }
> -
> void notify_one() noexcept
> {
> cv_.notify_one();
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list