[PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls being set
Kieran Bingham
kieran.bingham at ideasonboard.com
Tue Mar 4 22:13:09 CET 2025
Quoting Stefan Klug (2025-02-28 12:55:53)
> In the algorithms a lot of information get's logged in debug log level,
> but there is no place where the values sent to the sensor get logged.
> Add such a log message.
>
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> src/ipa/rkisp1/rkisp1.cpp | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index 7547d2f274f4..5f1583e8219b 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -455,6 +455,11 @@ void IPARkISP1::setControls(unsigned int frame)
> uint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain);
> uint32_t vblank = frameContext.agc.vblank;
>
> + LOG(IPARkISP1, Debug) << "Set controls frame " << frame
> + << ": exposure " << exposure
> + << ", gain " << frameContext.agc.gain
> + << ", vblank " << vblank;
> +
> ControlList ctrls(sensorControls_);
> ctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure));
> ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain));
> --
> 2.43.0
>
More information about the libcamera-devel
mailing list