[PATCH] README.rst: remove unnecessary dependency for qcam
Kieran Bingham
kieran.bingham at ideasonboard.com
Mon Mar 17 13:21:44 CET 2025
Quoting Quentin Schulz (2025-03-11 13:06:25)
> +Cc Ricardo, the original commit author, in case I'm missing something
>
> On 3/11/25 2:01 PM, Quentin Schulz wrote:
> > [foss+libcamera at 0leil.net appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > From: Quentin Schulz <quentin.schulz at cherry.de>
> >
> > The introducing commit (dff416a84b78 ("README: Add missing package for
> > Qt5 tools"); for Qt 5 originally) stated that without the dependency we
> > would get the following messages:
> >
> > Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO
> > Program lrelease-qt5 found: NO
> > Program lrelease found: NO found but need: '== 5.14.2'
> >
> > That is still the case but this actually is neither breaking the build
> > nor is it doing anything to the outcome of the build as qcam is bit to
> > bit identical with and without that package.
> >
> > Therefore, let's not mislead users to install an unnecessary package.
> >
> > Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
> > ---
> > This was tested within a debian:bookworm container with and without the
> > package, checked out both at master and introducing commit. qcam is bit
> > to bit identical in both cases.
That's the evidence I would look for in this, so
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Is this still the case on Qt6? I assume/infer that the reason you want
to remove this dependency is because something has changed in qt6 ?
If so - adding that to the commit message would help clarify things, as
you are removing a qt6 package, but only discussing qt5 in the commit.
> > ---
> > README.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/README.rst b/README.rst
> > index ae5126e25542a37d0c50287399486c56d2888af8..9dfef7eadb4640f77c28f82d42fadd54aa025641 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -85,7 +85,7 @@ for cam: [optional]
> > - libsdl2-dev: Enables the SDL sink
> >
> > for qcam: [optional]
> > - libtiff-dev qt6-base-dev qt6-tools-dev-tools
> > + libtiff-dev qt6-base-dev
> >
> > for tracing with lttng: [optional]
> > liblttng-ust-dev python3-jinja2 lttng-tools
> >
> > ---
> > base-commit: 39419ce431dbd4f34d8772bd31bb7f44a3534f86
> > change-id: 20250311-qttools-unneeded-468370441a64
> >
> > Best regards,
> > --
> > Quentin Schulz <quentin.schulz at cherry.de>
> >
>
More information about the libcamera-devel
mailing list