[PATCH v1 2/4] ipa: rpi: Add support for Raspberry Pi 5

[Kieran Bingham]

Quoting Naushir Patuck (2025-01-13 09:24:44)
> Add the Raspberry Pi 5 ISP (PiSP) IPA to libcamera. To include this IPA
> in the build, set the following meson option:
> 
> meson configure -Dipas=rpi/pisp
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
> ---
>  meson_options.txt                            |    3 +-
>  src/ipa/rpi/pisp/data/imx219.json            | 1187 ++++++++++++++++
>  src/ipa/rpi/pisp/data/imx219_noir.json       | 1112 +++++++++++++++
>  src/ipa/rpi/pisp/data/imx290.json            |  341 +++++
>  src/ipa/rpi/pisp/data/imx296.json            | 1194 ++++++++++++++++
>  src/ipa/rpi/pisp/data/imx296_16mm.json       | 1247 +++++++++++++++++
>  src/ipa/rpi/pisp/data/imx296_6mm.json        | 1247 +++++++++++++++++
>  src/ipa/rpi/pisp/data/imx296_mono.json       |  960 +++++++++++++
>  src/ipa/rpi/pisp/data/imx378.json            |  634 +++++++++
>  src/ipa/rpi/pisp/data/imx415.json            | 1159 ++++++++++++++++
>  src/ipa/rpi/pisp/data/imx462.json            |  342 +++++
>  src/ipa/rpi/pisp/data/imx477.json            | 1186 ++++++++++++++++
>  src/ipa/rpi/pisp/data/imx477_16mm.json       | 1240 +++++++++++++++++
>  src/ipa/rpi/pisp/data/imx477_6mm.json        | 1240 +++++++++++++++++
>  src/ipa/rpi/pisp/data/imx477_noir.json       | 1148 ++++++++++++++++
>  src/ipa/rpi/pisp/data/imx477_scientific.json |  546 ++++++++
>  src/ipa/rpi/pisp/data/imx519.json            |  634 +++++++++
>  src/ipa/rpi/pisp/data/imx708.json            | 1270 +++++++++++++++++
>  src/ipa/rpi/pisp/data/imx708_noir.json       | 1233 +++++++++++++++++
>  src/ipa/rpi/pisp/data/imx708_wide.json       | 1293 ++++++++++++++++++
>  src/ipa/rpi/pisp/data/imx708_wide_noir.json  | 1148 ++++++++++++++++
>  src/ipa/rpi/pisp/data/meson.build            |   29 +
>  src/ipa/rpi/pisp/data/ov5647.json            | 1186 ++++++++++++++++
>  src/ipa/rpi/pisp/data/ov5647_noir.json       | 1121 +++++++++++++++
>  src/ipa/rpi/pisp/data/ov64a40.json           | 1133 +++++++++++++++
>  src/ipa/rpi/pisp/data/ov9281_mono.json       |  215 +++
>  src/ipa/rpi/pisp/data/se327m12.json          |  639 +++++++++
>  src/ipa/rpi/pisp/data/uncalibrated.json      |  135 ++
>  src/ipa/rpi/pisp/meson.build                 |   49 +

Straight ack to all the existing tuning files, regardless of content.

>  src/ipa/rpi/pisp/pisp.cpp                    | 1068 +++++++++++++++
>  src/libcamera/control_ids_rpi.yaml           |   13 +

A quick check on these, though I also expect these to be easy, and have
been well tested already!

>  create mode 100644 src/ipa/rpi/pisp/meson.build
>  create mode 100644 src/ipa/rpi/pisp/pisp.cpp
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index f19bca91f38e..4db05a68325f 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -32,7 +32,8 @@ option('gstreamer',
>  
>  option('ipas',
>          type : 'array',
> -        choices : ['ipu3', 'mali-c55', 'rkisp1', 'rpi/vc4', 'simple', 'vimc'],
> +        choices : ['ipu3', 'mali-c55', 'rkisp1', 'rpi/pisp', 'rpi/vc4', 'simple',
> +                   'vimc'],
>          description : 'Select which IPA modules to build')
>  

For core additions:

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

<Snipped out all the tuning files>

In fact, the tuning files in here are so much data it breaks/doesn't
make it into patchwork!

Perhaps if we need any updates we might be best to move to a PR, but I'm
hoping we're ok without an update.

And snipping the rest of this file now too, for all RPi additions,
including RPi namespaced control addition:

Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>