[PATCH v1 4/4] pipeline: rpi: Add support for Raspberry Pi 5
Kieran Bingham
kieran.bingham at ideasonboard.com
Thu Mar 20 12:23:49 CET 2025
Quoting Naushir Patuck (2025-01-13 09:24:46)
> Add the Raspberry Pi 5 ISP (PiSP) pipeline handler to libcamera. To
> include this pipeline handler in the build, set the following meson
> option:
>
> meson configure -Dpipelines=rpi/pisp
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman at raspberrypi.com>
> ---
> Documentation/guides/pipeline-handler.rst | 2 +-
> include/libcamera/ipa/meson.build | 1 +
> include/libcamera/meson.build | 1 +
> meson.build | 1 +
> meson_options.txt | 1 +
For core:
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> .../pipeline/rpi/pisp/data/example.yaml | 45 +
> .../pipeline/rpi/pisp/data/meson.build | 8 +
> src/libcamera/pipeline/rpi/pisp/meson.build | 12 +
> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++
For RPi specifics:
There are a couple of interesting Todo items in the code base,
For instance:
LIBCAMERA_RPI_PISP_CONFIG_DUMP mentions it could be a vendor control
when available, and now it is. It should also be documented in
Documentation/environment_variables.rst.
I also saw there is dma sync handling that could be managed by
DmaSyncer() objects now instead of inline coding the ioctls. But that
likely wasn't available when this code was originally written.
I'd consider those fine for patches and improvements on top - and I
think it's important that we get a baseline in for RPi5 now.
Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
More information about the libcamera-devel
mailing list