[RFC PATCH v3 4/9] libcamera: process: Return error if already running

[Kieran Bingham]

Quoting Barnabás Pőcze (2025-03-25 18:08:16)
> Returning 0 when a running process is already managed can be
> confusing since the parameters might be completely different,
> causing the caller to mistakenly assume that the program it
> specified has been started.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>
> ---
>  src/libcamera/process.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp
> index aa9e8f519..716523acc 100644
> --- a/src/libcamera/process.cpp
> +++ b/src/libcamera/process.cpp
> @@ -241,7 +241,7 @@ int Process::start(const std::string &path,
>         int ret;
>  
>         if (pid_ > 0)
> -               return 0;
> +               return -EBUSY;

Seems reasonable. I assume we don't hit this anywhere currently ;-)


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>  
>         int childPid = fork();
>         if (childPid == -1) {
> -- 
> 2.49.0
>