[PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls being set

[Stefan Klug]

Hi Laurent,

Thank you for the review. 

On Wed, Mar 26, 2025 at 02:00:08PM +0200, Laurent Pinchart wrote:
> Hi Stefan,
> 
> Thank you for the patch.
> 
> On Fri, Feb 28, 2025 at 01:55:53PM +0100, Stefan Klug wrote:
> > In the algorithms a lot of information get's logged in debug log level,
> > but there is no place where the values sent to the sensor get logged.
> > Add such a log message.
> > 
> > Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> > ---
> >  src/ipa/rkisp1/rkisp1.cpp | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> > index 7547d2f274f4..5f1583e8219b 100644
> > --- a/src/ipa/rkisp1/rkisp1.cpp
> > +++ b/src/ipa/rkisp1/rkisp1.cpp
> > @@ -455,6 +455,11 @@ void IPARkISP1::setControls(unsigned int frame)
> >  	uint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain);
> >  	uint32_t vblank = frameContext.agc.vblank;
> >  
> > +	LOG(IPARkISP1, Debug) << "Set controls frame " << frame
> 
> Maybe s/frame/for frame/
> 
> > +			      << ": exposure " << exposure
> > +			      << ", gain " << frameContext.agc.gain
> > +			      << ", vblank " << vblank;
> 
> Our usual coding style would be
> 
> 	LOG(IPARkISP1, Debug)
> 		<< "Set controls for frame " << frame << ": exposure " << exposure
> 		<< ", gain " << frameContext.agc.gain << ", vblank " << vblank;

Oh I wasn't aware of that. I'll apply the fixes when merging.

Cheers,
Stefan

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> > +
> >  	ControlList ctrls(sensorControls_);
> >  	ctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure));
> >  	ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain));
> 
> -- 
> Regards,
> 
> Laurent Pinchart