[PATCH v6 5/5] pipeline: simple: Reset delayedCtrls at start.
Stefan Klug
stefan.klug at ideasonboard.com
Mon Mar 31 17:56:59 CEST 2025
Hi Stanislaw,
Thank you for the patch.
On Wed, Mar 05, 2025 at 02:52:56PM +0100, Stanislaw Gruszka wrote:
> Similar like in other pipelines (IPU3, rpi) avoid using stale
> values of DelayedControls class when the same camera is started
> second time.
>
> Co-developed-by: Hans de Goede <hdegoede at redhat.com>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>
Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com>
Cheers,
Stefan
> ---
> src/libcamera/pipeline/simple/simple.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 58aa3dba..659b1123 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -1376,6 +1376,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL
>
> video->bufferReady.connect(data, &SimpleCameraData::imageBufferReady);
>
> + data->delayedCtrls_->reset();
> if (frameStartEmitter) {
> ret = frameStartEmitter->setFrameStartEnabled(true);
> if (ret) {
> --
> 2.43.0
>
More information about the libcamera-devel
mailing list