[PATCH 4/9] libipa: agc_mean_luminance: Add debug logging
Kieran Bingham
kieran.bingham at ideasonboard.com
Mon Mar 31 18:37:57 CEST 2025
Quoting Stefan Klug (2025-03-31 15:43:43)
> When debugging the AEGC it is important to know when the constraints
> apply. As this is important information for anyone doing tuning file
> optimization, add it upstream.
>
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> ---
> src/ipa/libipa/agc_mean_luminance.cpp | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp
> index f617fde81101..9154f083a510 100644
> --- a/src/ipa/libipa/agc_mean_luminance.cpp
> +++ b/src/ipa/libipa/agc_mean_luminance.cpp
> @@ -468,12 +468,16 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,
> hist.interQuantileMean(constraint.qLo, constraint.qHi);
>
> if (constraint.bound == AgcConstraint::Bound::Lower &&
> - newGain > gain)
> + newGain > gain) {
> gain = newGain;
> + LOG(AgcMeanLuminance, Debug) << "Apply lower bound: " << gain << " to " << newGain;
> + }
>
> if (constraint.bound == AgcConstraint::Bound::Upper &&
> - newGain < gain)
> + newGain < gain) {
> gain = newGain;
> + LOG(AgcMeanLuminance, Debug) << "Apply upper bound: " << gain << " to " << newGain;
> + }
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> }
>
> return gain;
> --
> 2.43.0
>
More information about the libcamera-devel
mailing list