[PATCH 1/5] test: ipa: libipa: Add histogram tests

[Laurent Pinchart]

Hi Stefan,

Thank you for the patch.

On Mon, Mar 24, 2025 at 06:07:36PM +0100, Stefan Klug wrote:
> Add some basic tests for the histogram class.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> ---
>  test/ipa/libipa/histogram.cpp | 53 +++++++++++++++++++++++++++++++++++
>  test/ipa/libipa/meson.build   |  1 +
>  2 files changed, 54 insertions(+)
>  create mode 100644 test/ipa/libipa/histogram.cpp
> 
> diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp
> new file mode 100644
> index 000000000000..220a329e33b3
> --- /dev/null
> +++ b/test/ipa/libipa/histogram.cpp
> @@ -0,0 +1,53 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Copyright (C) 2024, Ideas on Board Oy
> + *
> + * Histogram tests
> + */
> +
> +#include "../src/ipa/libipa/histogram.h"
> +
> +#include <cmath>
> +#include <iostream>
> +#include <map>
> +#include <stdint.h>
> +
> +#include "test.h"
> +
> +using namespace std;
> +using namespace libcamera;
> +using namespace ipa;
> +
> +#define ASSERT_EQ(a, b)                    \
> +	if (!((a) == (b))) {               \
> +		printf(#a " != " #b "\n"); \

We use std::cout.

> +		return TestFail;           \
> +	}

One day we should really convert unit tests to use exceptions.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +
> +class HistogramTest : public Test
> +{
> +protected:
> +	int run()
> +	{
> +		auto hist = Histogram({ { 50, 50 } });
> +
> +		ASSERT_EQ(hist.bins(), 2);
> +		ASSERT_EQ(hist.total(), 100);
> +
> +		ASSERT_EQ(hist.cumulativeFrequency(1.0), 50);
> +		ASSERT_EQ(hist.cumulativeFrequency(1.5), 75);
> +		ASSERT_EQ(hist.cumulativeFrequency(2.0), 100);
> +
> +		ASSERT_EQ(hist.quantile(0.0), 0.0);
> +		ASSERT_EQ(hist.quantile(1.0), 2.0);
> +		ASSERT_EQ(hist.quantile(0.5), 1.0);
> +
> +		ASSERT_EQ(hist.interQuantileMean(0.0, 1.0), 1.0);
> +		ASSERT_EQ(hist.interQuantileMean(0.0, 0.5), 0.5);
> +		ASSERT_EQ(hist.interQuantileMean(0.5, 1.0), 1.5);
> +
> +		return TestPass;
> +	}
> +};
> +
> +TEST_REGISTER(HistogramTest)
> diff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build
> index eaf4b49a187c..f094c1593f1b 100644
> --- a/test/ipa/libipa/meson.build
> +++ b/test/ipa/libipa/meson.build
> @@ -2,6 +2,7 @@
>  
>  libipa_test = [
>      {'name': 'fixedpoint', 'sources': ['fixedpoint.cpp']},
> +    {'name': 'histogram', 'sources': ['histogram.cpp']},
>      {'name': 'interpolator', 'sources': ['interpolator.cpp']},
>  ]
>  

-- 
Regards,

Laurent Pinchart