[PATCH] utils: raspberrypi: ctt: Fix integer division error calculating LSC cell size
Kieran Bingham
kieran.bingham at ideasonboard.com
Wed May 7 19:28:59 CEST 2025
Quoting David Plowman (2025-05-07 16:31:03)
> The cell sizes must be cast to integers as the parameters that
> were passed in may be floats.
>
> Bug: https://github.com/raspberrypi/libcamera/issues/260
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> Fixes: 36ba0e551507 ("utils: raspberrypi: ctt: Fix NaNs in lens shading tables")
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> utils/raspberrypi/ctt/ctt_alsc.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/raspberrypi/ctt/ctt_alsc.py b/utils/raspberrypi/ctt/ctt_alsc.py
> index f4fd09e3..5d8b2ced 100644
> --- a/utils/raspberrypi/ctt/ctt_alsc.py
> +++ b/utils/raspberrypi/ctt/ctt_alsc.py
> @@ -131,7 +131,7 @@ def alsc(Cam, Img, do_alsc_colour, plot=False, grid_size=(16, 12), max_gain=8.0)
> pixels.
> """
> w, h = Img.w/2, Img.h/2
> - dx, dy = (w - 1) // (grid_w - 1), (h - 1) // (grid_h - 1)
> + dx, dy = int((w - 1) // (grid_w - 1)), int((h - 1) // (grid_h - 1))
>
> """
> average the green channels into one
> --
> 2.34.1
>
More information about the libcamera-devel
mailing list