[PATCH] apps: qcam: Push the viewfinder role to vector

[Barnabás Pőcze]

2025. 05. 07. 23:06 keltezéssel, Kieran Bingham írta:
> In commit ee2b011b65c6 ("apps: cam: Try raw role if default viewfinder
> role fails"), the viewfinder role is specified as the default if no role
> is yet chosen.
> 
> This was unfortunately added by directly accessing the vector rather
> than extending the size when the vector is empty. Fix the code to push
> the default viewfinder role on to the back of the vector, increasing the
> size appropriately.
> 
> Fixes: ee2b011b65c6 ("apps: cam: Try raw role if default viewfinder role fails")
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>
Tested-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>


> ---
>   src/apps/qcam/main_window.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp
> index 224a7e5a693a..7e3f3da605c4 100644
> --- a/src/apps/qcam/main_window.cpp
> +++ b/src/apps/qcam/main_window.cpp
> @@ -357,7 +357,7 @@ int MainWindow::startCapture()
>   	/* Verify roles are supported. */
>   	switch (roles.size()) {
>   	case 0:
> -		roles[0] = StreamRole::Viewfinder;
> +		roles.push_back(StreamRole::Viewfinder);
>   		break;
>   	case 1:
>   		if (roles[0] != StreamRole::Viewfinder) {