[PATCH v8] gstreamer: Add GstVideoMeta support

Nicolas Dufresne nicolas at ndufresne.ca
Sat May 17 00:22:27 CEST 2025


Hi Laurent,

Le vendredi 16 mai 2025 à 14:54 +0200, Laurent Pinchart a écrit :
> On Fri, May 16, 2025 at 12:16:50PM +0200, Nicolas Dufresne wrote:
> > Hi,
> > 

...

> > > +		/* stride mismatch between camera stride and that calculated by video-info */
> > > +		if (static_cast<unsigned int>(info.stride[0]) != stream_cfg.stride &&
> > > +		    GST_VIDEO_INFO_FORMAT(&info) != GST_VIDEO_FORMAT_ENCODED) {
> 
> Nicolas, as copying frames is very expensive, should we log a message
> somewhere to warn the user ? I'm concerned we'll get bug reports for bad
> performance, and I'd like a way to know that copies are happening.

The video copy function already trace in the GST_PERFORMANCE debug category. This
global category is used to log all kind of heavy operations. Some people have
preferred a warning, but it is generally considered excessive. I leave to you
the final decision. Tracing in the commented context would result in a one time
warning, so would be appropriate if this is your preference.

Nicolas


More information about the libcamera-devel mailing list