[PATCH 1/2] libcamera/mali-c55: Remove tpgCodes_

Kieran Bingham kieran.bingham at ideasonboard.com
Wed May 21 18:25:06 CEST 2025


Quoting Laurent Pinchart (2025-05-21 17:16:12)
> On Wed, May 21, 2025 at 02:21:01PM +0100, Daniel Scally wrote:
> > MaliC55CameraData stores a vector of the TPG's mbus codes (if the
> > camera in question is a TPG). This is never used - remove it.
> > 
> > Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> > ---
> >  src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> > index a05e11fccf8dfde1a0eeda994afe2d78d884c530..35372ee1ed6f694166c395088c65509d32b9d1f2 100644
> > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> > @@ -131,7 +131,6 @@ private:
> >       void setSensorControls(const ControlList &sensorControls);
> >  
> >       std::string id_;
> > -     std::vector<unsigned int> tpgCodes_;
> >       std::vector<Size> tpgSizes_;
> >       Size tpgResolution_;
> >  };
> > @@ -180,9 +179,6 @@ void MaliC55CameraData::initTPGData()
> >       if (formats.empty())
> >               return;
> >  
> > -     tpgCodes_ = utils::map_keys(formats);
> > -     std::sort(tpgCodes_.begin(), tpgCodes_.end());
> > -
> >       for (const auto &format : formats) {
> >               const std::vector<SizeRange> &ranges = format.second;
> >               std::transform(ranges.begin(), ranges.end(), std::back_inserter(tpgSizes_),
> 
> -- 
> Regards,
> 
> Laurent Pinchart


More information about the libcamera-devel mailing list