<div id="geary-body" dir="auto"><div>Hi Laurent,</div></div><div id="geary-quote" dir="auto"><div>On Mon, Apr 20, 2020 at 00:33, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:</div><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">Since commit e75ef59e028e ("libcamera: device_enumerator_udev: Update
pending list in addUdevDevice") the populateMediaDevice() function
returns 0 on success instead of the number of missing dependencies,
resulting in a wrong number being logged. Fix it.
Fixes: e75ef59e028e ("libcamera: device_enumerator_udev: Update pending list in addUdevDevice")
Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>>
---
src/libcamera/device_enumerator_udev.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp
index 9cbc7e47d2d9..2e33c898aeef 100644
--- a/src/libcamera/device_enumerator_udev.cpp
+++ b/src/libcamera/device_enumerator_udev.cpp
@@ -94,7 +94,8 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)
if (!deps.empty()) {
LOG(DeviceEnumerator, Debug)
<< "Defer media device " << media->deviceNode()
- << " due to " << ret << " missing dependencies";
+ << " due to " << deps.size()
+ << " missing dependencies";
pending_.emplace_back(std::move(media), std::move(deps));
MediaDeviceDeps *mediaDeps = &pending_.back();</div></blockquote><span style="white-space: pre-wrap;"><div><br></div><div>LGTM.</div></span><div><span style="white-space: pre-wrap;"><br></span></div><div><span style="white-space: pre-wrap;">Reviewed-by: Umang Jain <email@uajain.com></span></div><div><span style="white-space: pre-wrap;"><br></span><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;"><div>--
</div>Regards,
Laurent Pinchart
</div></blockquote></div></div><img src="https://u15657259.ct.sendgrid.net/wf/open?upn=GCEip0g28ftA9O9fsCR2M7x08El53O4YVYtHuSI-2FrLwtytoSlmO-2FnSq-2B0q807R-2FEH3ON-2BrNtspFA1WqRf60G7b5faMqcz5VeVVRG-2B13sNobVZ5Ddl0YFD1bQXIFPAUdhyD51HNaFTaZMPP5w672LJvg5oNB1g8KdpGvoTc5Grl0cDfo19PU3-2Bit-2BJ0hDutc-2Bfk8-2BZaH7OilexH4PtPky-2FXU4f-2FynpYZ2OTBcW41A5ao-2FZ8THZdsX-2BV5pJ27AOd4vD3OD-2F82AzZ0inFwvinUbQA-3D-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>