<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Chris,<br>
</p>
<div class="moz-cite-prefix">On 6/25/20 2:03 PM, Chris Chinchilla
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<title></title>
<div name="messageBodySection">
<div dir="auto">Yes, I resent it as people told me it was
missing tags :)<br>
<br>
So it’s missing more tags now? I admit, I didn’t see the
reviewed by tags appear anywhere.<br>
</div>
</div>
</blockquote>
Did you see commit history in libcamera git repo? <br>
<br>
$ cd /path/to/libcamera/repo<br>
$ git log<br>
<br>
See couple of commits and their messages:<br>
<br>
They will have:<br>
* Signed-off-by tag - This generally belongs to the author of the
commit <br>
* Reviewed-by tag - This is to denote who reviewed your commit.<br>
<br>
Obviously, v1 won't have any Reviewed-by tags. So, when from submit
next version (v2, v3...)<br>
You need to append the commit message, if you have got "Reviewed-by"
tag by the reviewer<br>
when they reviewed our patches on the mailing list. <br>
<p>You need 2-or-more "Reviewed-by tags" to get your patches merged.
<br>
This is not a hard rule but that's what I have been told :) </p>
<blockquote type="cite"
cite="mid:603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark">
<div name="messageBodySection">
<div dir="auto">
<br>
So to clarify, to get this right, I need to resend again with
a v3 and add reviewed by tags?<br>
</div>
</div>
</blockquote>
Yes, apart from the fixes pointed out in the last review (if any),
you need to send a next version (v3),<br>
making sure it has signoff and reviewed-by tags included from the
review. This is generic workflow.<br>
<br>
Since, I checked, this particular patch acutally fixes an old
commit, you need to specify: "Fixes: "<br>
tag as mentioned in the previous review. So in total, you will have
1 "Fixes: " tag, 1 Signoff tag<br>
and 2 Reviewed-by tags (mine and Laurent's).<br>
<br>
Hope I have made this clear. Please feel free to reach out if you
have any more questions.<br>
<blockquote type="cite"
cite="mid:603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark">
<div name="messageSignatureSection"><br>
<div class="matchFont">Chris</div>
</div>
<div name="messageReplySection">On 23 Jun 2020, 19:38 +0200, Umang
Jain <a class="moz-txt-link-rfc2396E" href="mailto:email@uajain.com"><email@uajain.com></a>, wrote:<br>
<blockquote type="cite" style="border-left-color: grey;
border-left-width: thin; border-left-style: solid; margin: 5px
5px;padding-left: 10px;">Hi Chris,<br>
<br>
Did you re-send this patch by mistake? It's identical with the
patch<br>
you sent on 6/15/2020.<br>
<br>
When you re-send the patch, you need to also mention that the
patch is<br>
the second (or third, fourth ...) iteration of the initial
patch.<br>
You can do that by adding "-v2" to "git format-patch ..."
commandline<br>
to denote that it's the second version of that patch.<br>
<br>
Also, since you got Reviewed-by tags by me and Laurent, you
need to collect<br>
them too and add it to your commit message while re-sending
them for the<br>
second round of review.<br>
<br>
On 6/23/20 4:27 PM, <a class="moz-txt-link-abbreviated" href="mailto:chris@gregariousmammal.com">chris@gregariousmammal.com</a> wrote:<br>
<blockquote type="cite">From: Chris Chinchilla
<a class="moz-txt-link-rfc2396E" href="mailto:chris@gregariousmammal.com"><chris@gregariousmammal.com></a><br>
<br>
Fix incorrect method in cameradata docs<br>
<br>
Fixes: b581b9576abd ("libcamera: pipeline_handler: Make
pipeline-specific data mandatory")<br>
Signed-off-by: Chris Chinchilla
<a class="moz-txt-link-rfc2396E" href="mailto:chris@gregariousmammal.com"><chris@gregariousmammal.com></a><br>
---<br>
src/libcamera/pipeline_handler.cpp | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/libcamera/pipeline_handler.cpp
b/src/libcamera/pipeline_handler.cpp<br>
index 14dfba0..15cdc17 100644<br>
--- a/src/libcamera/pipeline_handler.cpp<br>
+++ b/src/libcamera/pipeline_handler.cpp<br>
@@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)<br>
*<br>
* Pipeline handlers are expected to extend this base class
with platform<br>
* specific implementation, associate instances of the
derived classes<br>
- * using the setCameraData() method, and access them at a
later time<br>
+ * using the registerCamera() method, and access them at a
later time<br>
* with cameraData().<br>
*/<br>
<br>
</blockquote>
</blockquote>
</div>
</blockquote>
</body>
</html>