<div dir="auto"><div>Hi Niklas,<div dir="auto"><br></div><div dir="auto"><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 1 Aug 2020, 10:22 am Niklas Söderlund, <<a href="mailto:niklas.soderlund@ragnatech.se" target="_blank" rel="noreferrer">niklas.soderlund@ragnatech.se</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Naushir,<br>
<br>
On 2020-07-30 09:39:38 +0100, Naushir Patuck wrote:<br>
> Hi all,<br>
> <br>
> Is there any further changes anyone would like me to make for this<br>
> series? I know Laurent had comments on what I was trying to achieve<br>
> in patches 09/10 and 10/10 - I have made some minor changes with<br>
> variable names and comments to hopefully explain the code better. If<br>
> there are other clarifications to be made, please let me know and I<br>
> will be happy to do so.<br>
<br>
On one hand I think this series improves the pipeline but at the same <br>
time it's hard to know if the direction will solve the zero-copy problem <br>
as that patch have been dropped from the series. If you and others are <br>
pushing for this series to be integrated I would be fine doing so, but <br>
if possible it would be nice to see a version with the zero-copy raw <br>
feature added back.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">All the patches in the series will enable zero-copy RAW (or any other stream really) captures in the raspberry pi platform. I've been testing this with cam, qcam, and our in-house libcamera application.</div><div dir="auto"><br></div><div dir="auto">The only feature missing is that applications cannot use buffers that have not been allocated or exported by the v4l2 videodevice (e.g. a random dmabuf), but none of the above applications do that right now as far as I can tell. I have a patch series waiting to add support for this and will submit for review once this is gone through. Hope that is ok?</div><div dir="auto"><br></div><div dir="auto">Regards,</div><div dir="auto">Naush</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
> <br>
> Regards,<br>
> Naush<br>
> <br>
> On Fri, 24 Jul 2020 at 08:22, Naushir Patuck <<a href="mailto:naush@raspberrypi.com" rel="noreferrer noreferrer" target="_blank">naush@raspberrypi.com</a>> wrote:<br>
> ><br>
> > Hi,<br>
> ><br>
> > This is patchset v5 of the zero copy RAW stream work for the Raspberry Pi platform.<br>
> > All minor changes in the review feedback have been addressed. The only other difference<br>
> > is in patch 9/10 where I have renamed requeueBuffers_ to requestBuffers_ and made minor<br>
> > changes to the comments to hopefully make the usage slightly more understandable. I<br>
> > have left the review tags in place, as there is no functional change, hope that is ok.<br>
> ><br>
> > Regards,<br>
> > Naush<br>
> ><br>
> > Naushir Patuck (10):<br>
> > libcamera: pipeline: raspberrypi: Move RPiStream into a separate file<br>
> > libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling<br>
> > libcamera: request: Add log point on a completed request<br>
> > libcamera: pipeline: raspberrypi: Add some debug logging<br>
> > libcamera: pipeline: raspberrypi: Increase the number of RAW buffers<br>
> > libcamera: pipeline: raspberrypi: Remove const qualifier from<br>
> > RPiStream<br>
> > libcamera: pipeline: raspberrypi: Rework stream buffer logic for<br>
> > zero-copy<br>
> > libcamera: pipeline: raspberrypi: Fix bug in passing configuration to<br>
> > IPA<br>
> > libcamera: pipeline: raspberrypi: Add more robust stream buffer logic<br>
> > libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer<br>
> > cookie<br>
> ><br>
> > include/libcamera/ipa/raspberrypi.h | 2 +-<br>
> > src/ipa/raspberrypi/raspberrypi.cpp | 20 +-<br>
> > .../pipeline/raspberrypi/meson.build | 1 +<br>
> > .../pipeline/raspberrypi/raspberrypi.cpp | 522 +++++++-----------<br>
> > .../pipeline/raspberrypi/rpi_stream.cpp | 216 ++++++++<br>
> > .../pipeline/raspberrypi/rpi_stream.h | 131 +++++<br>
> > src/libcamera/request.cpp | 3 +<br>
> > 7 files changed, 563 insertions(+), 332 deletions(-)<br>
> > create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp<br>
> > create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h<br>
> ><br>
> > --<br>
> > 2.25.1<br>
> ><br>
> _______________________________________________<br>
> libcamera-devel mailing list<br>
> <a href="mailto:libcamera-devel@lists.libcamera.org" rel="noreferrer noreferrer" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
> <a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer noreferrer noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
<br>
-- <br>
Regards,<br>
Niklas Söderlund<br>
</blockquote></div></div></div>