<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><tt>Hi Niklas, Laurent,</tt><br>
</p>
<div class="moz-cite-prefix">On 8/3/20 5:01 AM, Laurent Pinchart
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20200802233110.GK23801@pendragon.ideasonboard.com">
<pre class="moz-quote-pre" wrap="">Hi Niklas,
Thank you for the patch.
On Mon, Aug 03, 2020 at 01:16:52AM +0200, Niklas Söderlund wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">The monitor_ and notifier_ pointers are acted on in the destructor if
not set to nullptr, the pointers are however first initialized in
enumerate(). If the object is deleted without enumerate() being called
the destructor acts on uninitialized pointers, fix this by initializing
them to nullptr.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Note that monitor_ is created in init(), not enumerate(). The issue is
still the same though, only the commit message should be updated.
Reviewed-by: Laurent Pinchart <a class="moz-txt-link-rfc2396E" href="mailto:laurent.pinchart@ideasonboard.com"><laurent.pinchart@ideasonboard.com></a></pre>
</blockquote>
Ditto. The commit message is the only change needed.<br>
<span style="color: rgb(255, 255, 255); font-family: monospace; font-size: 13.3333px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(0, 0, 0); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;"></span>Reviewed-by:
Umang Jain <a class="moz-txt-link-rfc2396E"
href="mailto:email@uajain.com"><email@uajain.com></a>
<blockquote type="cite"
cite="mid:20200802233110.GK23801@pendragon.ideasonboard.com">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Signed-off-by: Niklas Söderlund <a class="moz-txt-link-rfc2396E" href="mailto:niklas.soderlund@ragnatech.se"><niklas.soderlund@ragnatech.se></a>
---
src/libcamera/device_enumerator_udev.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp
index 56ca4dc2804b46b9..96689daa5dd113dc 100644
--- a/src/libcamera/device_enumerator_udev.cpp
+++ b/src/libcamera/device_enumerator_udev.cpp
@@ -27,7 +27,7 @@ namespace libcamera {
LOG_DECLARE_CATEGORY(DeviceEnumerator)
DeviceEnumeratorUdev::DeviceEnumeratorUdev()
- : udev_(nullptr)
+ : udev_(nullptr), monitor_(nullptr), notifier_(nullptr)
{
}
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
</html>