<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Niklas,<br>
</p>
<div class="moz-cite-prefix">On 8/3/20 4:20 AM, Niklas Söderlund
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20200802225023.346784-1-niklas.soderlund@ragnatech.se">
<pre class="moz-quote-pre" wrap="">Instead of marking each individual overloaded function with final mark
the whole class as final. This aligns the sysfs and udev based
DeviceEnumerator implementations.
Signed-off-by: Niklas Söderlund <a class="moz-txt-link-rfc2396E" href="mailto:niklas.soderlund@ragnatech.se"><niklas.soderlund@ragnatech.se></a></pre>
</blockquote>
<span style="color: rgb(255, 255, 255); font-family: monospace; font-size: 13.3333px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(0, 0, 0); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">
</span>Reviewed-by: Umang Jain <a class="moz-txt-link-rfc2396E" href="mailto:email@uajain.com"><email@uajain.com></a><br>
<p>Thanks.<br>
</p>
<blockquote type="cite"
cite="mid:20200802225023.346784-1-niklas.soderlund@ragnatech.se">
<pre class="moz-quote-pre" wrap="">
---
include/libcamera/internal/device_enumerator_udev.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h
index 2e7916a0b280f60d..6f45be0c1c423d02 100644
--- a/include/libcamera/internal/device_enumerator_udev.h
+++ b/include/libcamera/internal/device_enumerator_udev.h
@@ -26,14 +26,14 @@ class EventNotifier;
class MediaDevice;
class MediaEntity;
-class DeviceEnumeratorUdev : public DeviceEnumerator
+class DeviceEnumeratorUdev final : public DeviceEnumerator
{
public:
DeviceEnumeratorUdev();
~DeviceEnumeratorUdev();
- int init() final;
- int enumerate() final;
+ int init();
+ int enumerate();
private:
using DependencyMap = std::map<dev_t, std::list<MediaEntity *>>;
</pre>
</blockquote>
</body>
</html>