<div dir="ltr"><div dir="ltr">Hi Tomi,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 22 Oct 2020 at 09:17, Tomi Valkeinen <<a href="mailto:tomi.valkeinen@iki.fi" target="_blank">tomi.valkeinen@iki.fi</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The method calls setFormat(), stores the return value, but then does not<br>
do anything with the return value. I presume it is meant to fail and<br>
return the error.<br>
<br>
Signed-off-by: Tomi Valkeinen <<a href="mailto:tomi.valkeinen@iki.fi" target="_blank">tomi.valkeinen@iki.fi</a>><br>
---<br>
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 ++<br>
 1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
index dd62dfc7..aa8d9340 100644<br>
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
@@ -586,6 +586,8 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)<br>
         * because of flips in the sensor.<br>
         */<br>
        ret = data->isp_[Isp::Input].dev()->setFormat(&sensorFormat);<br>
+       if (ret)<br>
+               return ret;<br></blockquote><div><br></div><div>Looks good to me.</div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
        /*<br>
         * See which streams are requested, and route the user<br>
-- <br>
2.25.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>