<div dir="ltr"><div dir="ltr">Hi David,<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 16 Nov 2020 at 16:49, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The method formerly known as divvyupExposure is given a more<br>
understandable name.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 ++++----<br>
 src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +-<br>
 2 files changed, 5 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp<br>
index c4379b99..d29b1156 100644<br>
--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp<br>
+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp<br>
@@ -225,7 +225,7 @@ void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,<br>
        // write the results into the metadata we've been given.<br>
        if (status_.total_exposure_value) {<br>
                housekeepConfig();<br>
-               divvyupExposure();<br>
+               divideUpExposure();<br>
                writeAndFinish(metadata, false);<br>
        }<br>
 }<br>
@@ -304,9 +304,9 @@ void Agc::Process(StatisticsPtr &stats, Metadata *image_metadata)<br>
        bool desaturate = applyDigitalGain(image_metadata, gain, target_Y);<br>
        // The results have to be filtered so as not to change too rapidly.<br>
        filterExposure(desaturate);<br>
-       // The last thing is to divvy up the exposure value into a shutter time<br>
+       // The last thing is to divide up the exposure value into a shutter time<br>
        // and analogue_gain, according to the current exposure mode.<br>
-       divvyupExposure();<br>
+       divideUpExposure();<br>
        // Finally advertise what we've done.<br>
        writeAndFinish(image_metadata, desaturate);<br>
 }<br>
@@ -545,7 +545,7 @@ void Agc::filterExposure(bool desaturate)<br>
                           << " no dg " << filtered_.total_exposure_no_dg;<br>
 }<br>
<br>
-void Agc::divvyupExposure()<br>
+void Agc::divideUpExposure()<br>
 {<br>
        // Sending the fixed shutter/gain cases through the same code may seem<br>
        // unnecessary, but it will make more sense when extend this to cover<br>
diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp<br>
index 5a02df4e..2442fc03 100644<br>
--- a/src/ipa/raspberrypi/controller/rpi/agc.hpp<br>
+++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp<br>
@@ -89,7 +89,7 @@ private:<br>
        bool applyDigitalGain(Metadata *image_metadata, double gain,<br>
                              double target_Y);<br>
        void filterExposure(bool desaturate);<br>
-       void divvyupExposure();<br>
+       void divideUpExposure();<br>
        void writeAndFinish(Metadata *image_metadata, bool desaturate);<br>
        AgcMeteringMode *metering_mode_;<br>
        AgcExposureMode *exposure_mode_;<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>