<div dir="ltr"><div dir="ltr">Hi David,<div><br></div></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 16 Nov 2020 at 16:49, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Use memset in the constructor, it is tidier and initialises<br>
everything.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br>
---<br>
 src/ipa/raspberrypi/controller/rpi/agc.cpp | 13 ++++++-------<br>
 1 file changed, 6 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp<br>
index 7c7944e8..1037f968 100644<br>
--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp<br>
+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp<br>
@@ -157,14 +157,13 @@ Agc::Agc(Controller *controller)<br>
          exposure_mode_(nullptr), constraint_mode_(nullptr),<br>
          frame_count_(0), lock_count_(0)<br>
 {<br>
+       // Setting status_.total_exposure_value_ to zero initially tells us<br>
+       // it's not been calculated yet (i.e. Process hasn't yet run).<br>
+       memset(&status_, 0, sizeof(status_));<br>
        ev_ = status_.ev = 1.0;<br>
-       flicker_period_ = status_.flicker_period = 0.0;<br>
-       fixed_shutter_ = status_.fixed_shutter = 0;<br>
-       fixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;<br>
-       // set to zero initially, so we can tell it's not been calculated<br>
-       status_.total_exposure_value = 0.0;<br>
-       status_.target_exposure_value = 0.0;<br>
-       status_.locked = false;<br>
+       flicker_period_ = 0.0;<br>
+       fixed_shutter_ = 0;<br>
+       fixed_analogue_gain_ = 0.0;<br></blockquote><div><br></div><div>Minor nit, but could these be initialised by the constructor's initialiser list?  Apart from that:</div><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 }<br>
<br>
 char const *Agc::Name() const<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>