<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for the patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 26 Nov 2020 at 14:23, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">AE/AGC "disabled" is now handled better by the algorithm for itself,<br>
so it no longer needs to be "resumed" before setting fixed shutter or<br>
gain values.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br></blockquote><div><br></div><div>Reviewed-by Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 src/ipa/raspberrypi/raspberrypi.cpp | 8 --------<br>
 1 file changed, 8 deletions(-)<br>
<br>
diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp<br>
index 9853a343..29d48b1b 100644<br>
--- a/src/ipa/raspberrypi/raspberrypi.cpp<br>
+++ b/src/ipa/raspberrypi/raspberrypi.cpp<br>
@@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)<br>
                        /* This expects units of micro-seconds. */<br>
                        agc->SetFixedShutter(ctrl.second.get<int32_t>());<br>
<br>
-                       /* For the manual values to take effect, AGC must be unpaused. */<br>
-                       if (agc->IsPaused())<br>
-                               agc->Resume();<br>
-<br>
                        libcameraMetadata_.set(controls::ExposureTime, ctrl.second.get<int32_t>());<br>
                        break;<br>
                }<br>
@@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)<br>
                        ASSERT(agc);<br>
                        agc->SetFixedAnalogueGain(ctrl.second.get<float>());<br>
<br>
-                       /* For the manual values to take effect, AGC must be unpaused. */<br>
-                       if (agc->IsPaused())<br>
-                               agc->Resume();<br>
-<br>
                        libcameraMetadata_.set(controls::AnalogueGain,<br>
                                               ctrl.second.get<float>());<br>
                        break;<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>