<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 2 Dec 2020 at 11:53, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This makes it possible to tell whether we're starting the sensor for<br>
the first time, or whether it's happening because of a mode switch or<br>
because the camera has been paused and re-started. Depending on this,<br>
some sensors may require us to drop different numbers of frames.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
src/ipa/raspberrypi/raspberrypi.cpp | 7 ++++++-<br>
1 file changed, 6 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp<br>
index 69be5e4e..b8298768 100644<br>
--- a/src/ipa/raspberrypi/raspberrypi.cpp<br>
+++ b/src/ipa/raspberrypi/raspberrypi.cpp<br>
@@ -67,7 +67,7 @@ public:<br>
IPARPi()<br>
: lastMode_({}), controller_(), controllerInit_(false),<br>
frameCount_(0), checkCount_(0), mistrustCount_(0),<br>
- lsTable_(nullptr)<br>
+ lsTable_(nullptr), firstStart_(true)<br>
{<br>
}<br>
<br>
@@ -145,6 +145,9 @@ private:<br>
/* LS table allocation passed in from the pipeline handler. */<br>
FileDescriptor lsTableHandle_;<br>
void *lsTable_;<br>
+<br>
+ /* Distinguish the first camera start from others. */<br>
+ bool firstStart_;<br>
};<br>
<br>
int IPARPi::init(const IPASettings &settings)<br>
@@ -179,6 +182,8 @@ int IPARPi::start(const IPAOperationData &ipaConfig, IPAOperationData *result)<br>
result->operation |= RPi::IPA_CONFIG_SENSOR;<br>
}<br>
<br>
+ firstStart_ = false;<br>
+<br>
return 0;<br>
}<br>
<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>