<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 2 Dec 2020 at 11:53, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The ov5647 delivers two under-exposed frames at startup, even when<br>
the exposure and gain are explicitly programmed. The system needs to<br>
be told to drop these.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br>
---<br>
 src/ipa/raspberrypi/cam_helper_ov5647.cpp | 10 ++++++++++<br>
 1 file changed, 10 insertions(+)<br>
<br>
diff --git a/src/ipa/raspberrypi/cam_helper_ov5647.cpp b/src/ipa/raspberrypi/cam_helper_ov5647.cpp<br>
index dc5d8275..0b841cd1 100644<br>
--- a/src/ipa/raspberrypi/cam_helper_ov5647.cpp<br>
+++ b/src/ipa/raspberrypi/cam_helper_ov5647.cpp<br>
@@ -19,6 +19,7 @@ public:<br>
        uint32_t GainCode(double gain) const override;<br>
        double Gain(uint32_t gain_code) const override;<br>
        void GetDelays(int &exposure_delay, int &gain_delay) const override;<br>
+       unsigned int HideFramesStartup() const override;<br>
        unsigned int HideFramesModeSwitch() const override;<br>
        unsigned int MistrustFramesStartup() const override;<br>
        unsigned int MistrustFramesModeSwitch() const override;<br>
@@ -54,6 +55,15 @@ void CamHelperOv5647::GetDelays(int &exposure_delay, int &gain_delay) const<br>
        gain_delay = 2;<br>
 }<br>
<br>
+unsigned int CamHelperOv5647::HideFramesStartup() const<br>
+{<br>
+       /*<br>
+        * On startup, we get a couple of under-exposed frames which<br>
+        * we don't want shown.<br>
+        */<br>
+       return 2;<br>
+}<br>
+<br></blockquote><div><br></div><div>Ah, that might answer part of my question on patch 4/5.  But we still don't account for AWB/LS convergence.  Maybe we don't care?</div><div><br></div><div>Regards,</div><div>Naush</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 unsigned int CamHelperOv5647::HideFramesModeSwitch() const<br>
 {<br>
        /*<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>