<div dir="ltr"><div dir="ltr">Hi Laurent,<div><br></div><div>Thank you for your review feedback.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 20 Dec 2020 at 05:54, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Naush,<br>
<br>
Thank you for the patch.<br>
<br>
On Fri, Dec 18, 2020 at 10:06:27AM +0000, Naushir Patuck wrote:<br>
> Set the maximum shutter speed for the normal exposure profile to 66ms.<br>
> Set the maximum shutter speed for the sport exposure profile to 33ms.<br>
<br>
It would be nice if we could add a sentence to explain why. The content<br>
of the patch otherwise looks good.<br></blockquote><div><br></div><div>I can add a quick line of text to explain this a bit more in the next revision.</div><div><br></div><div>Regards,</div><div>Naush</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Reviewed-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
<br>
> Add a long exposure profile to allow shutter speeds of up to 120ms.<br>
> <br>
> Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> Reviewed-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br>
> Tested-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br>
> ---<br>
>  src/ipa/raspberrypi/data/imx219.json | 15 +++++++++++++--<br>
>  src/ipa/raspberrypi/data/imx477.json | 15 +++++++++++++--<br>
>  src/ipa/raspberrypi/data/ov5647.json | 15 +++++++++++++--<br>
>  3 files changed, 39 insertions(+), 6 deletions(-)<br>
> <br>
> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json<br>
> index 212f8b9a..1ec338be 100644<br>
> --- a/src/ipa/raspberrypi/data/imx219.json<br>
> +++ b/src/ipa/raspberrypi/data/imx219.json<br>
> @@ -133,7 +133,7 @@<br>
>              {<br>
>                  "shutter":<br>
>                  [<br>
> -                    100, 10000, 30000, 30000, 30000<br>
> +                    100, 10000, 30000, 60000, 66666<br>
>                  ],<br>
>                  "gain":<br>
>                  [<br>
> @@ -144,7 +144,18 @@<br>
>              {<br>
>                  "shutter":<br>
>                  [<br>
> -                    100, 5000, 10000, 20000, 30000<br>
> +                    100, 5000, 10000, 20000, 33333<br>
> +                ],<br>
> +                "gain":<br>
> +                [<br>
> +                    1.0, 2.0, 4.0, 6.0, 6.0<br>
> +                ]<br>
> +            },<br>
> +            "long":<br>
> +            {<br>
> +                "shutter":<br>
> +                [<br>
> +                    100, 10000, 30000, 60000, 120000<br>
>                  ],<br>
>                  "gain":<br>
>                  [<br>
> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json<br>
> index 12fe2f41..9bee3f16 100644<br>
> --- a/src/ipa/raspberrypi/data/imx477.json<br>
> +++ b/src/ipa/raspberrypi/data/imx477.json<br>
> @@ -133,7 +133,7 @@<br>
>              {<br>
>                  "shutter":<br>
>                  [<br>
> -                    100, 10000, 30000, 60000, 120000<br>
> +                    100, 10000, 30000, 60000, 66666<br>
>                  ],<br>
>                  "gain":<br>
>                  [<br>
> @@ -144,7 +144,18 @@<br>
>              {<br>
>                  "shutter":<br>
>                  [<br>
> -                    100, 5000, 10000, 20000, 120000<br>
> +                    100, 5000, 10000, 20000, 33333<br>
> +                ],<br>
> +                "gain":<br>
> +                [<br>
> +                    1.0, 2.0, 4.0, 6.0, 6.0<br>
> +                ]<br>
> +            },<br>
> +            "long":<br>
> +            {<br>
> +                "shutter":<br>
> +                [<br>
> +                    100, 10000, 30000, 60000, 120000<br>
>                  ],<br>
>                  "gain":<br>
>                  [<br>
> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json<br>
> index 3d8a7c8f..1a354f7c 100644<br>
> --- a/src/ipa/raspberrypi/data/ov5647.json<br>
> +++ b/src/ipa/raspberrypi/data/ov5647.json<br>
> @@ -133,7 +133,7 @@<br>
>              {<br>
>                  "shutter":<br>
>                  [<br>
> -                    100, 10000, 30000, 30000, 30000<br>
> +                    100, 10000, 30000, 60000, 66666<br>
>                  ],<br>
>                  "gain":<br>
>                  [<br>
> @@ -144,7 +144,18 @@<br>
>              {<br>
>                  "shutter":<br>
>                  [<br>
> -                    100, 5000, 10000, 20000, 30000<br>
> +                    100, 5000, 10000, 20000, 33333<br>
> +                ],<br>
> +                "gain":<br>
> +                [<br>
> +                    1.0, 2.0, 4.0, 6.0, 6.0<br>
> +                ]<br>
> +            },<br>
> +            "long":<br>
> +            {<br>
> +                "shutter":<br>
> +                [<br>
> +                    100, 10000, 30000, 60000, 120000<br>
>                  ],<br>
>                  "gain":<br>
>                  [<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>