<div dir="ltr">Hi all,<div><br></div><div>Gentle ping to see if this can be finalised.</div><div><br></div><div>Many thanks,</div><div>Naush</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 6 Jan 2021 at 10:07, Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi all,<br>
<br>
Here is the next iteration of the FPS control patchset. This version has all the various nits fixed:<br>
<br>
- Clip -> Clamp in a comment.<br>
- Member definitions on separate lines to match the rest of the file.<br>
- Ensure we handle the case where minFrameDuration > maxFrameDuration without breaking.<br>
- Expanded wording in the commit message for 3/3.<br>
<br>
The documentation for frameDurations control has been updated as well. I've included a line about resetting to default values, together with a todo to rationalise this as well as for other controls. Also simplified the text surrounding metadata return values.<br>
<br>
Many thanks,<br>
Naush<br>
<br>
Naushir Patuck (3):<br>
libcamera: controls: Add frame duration control<br>
libcamera: raspberrypi: Add control of sensor vblanking<br>
ipa: raspberrypi: config: Update shutter speeds for imx219/477 and<br>
ov5647<br>
<br>
include/libcamera/ipa/raspberrypi.h | 1 +<br>
src/ipa/raspberrypi/cam_helper.cpp | 35 +++++++++++-<br>
src/ipa/raspberrypi/cam_helper.hpp | 15 ++++-<br>
src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++-<br>
src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++-<br>
src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++-<br>
src/ipa/raspberrypi/data/imx219.json | 15 ++++-<br>
src/ipa/raspberrypi/data/imx477.json | 15 ++++-<br>
src/ipa/raspberrypi/data/ov5647.json | 15 ++++-<br>
src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++++---<br>
src/libcamera/control_ids.yaml | 38 +++++++++++++<br>
.../pipeline/raspberrypi/raspberrypi.cpp | 3 +-<br>
12 files changed, 207 insertions(+), 21 deletions(-)<br>
<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div>