<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your review feedback.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 20 Jan 2021 at 10:00, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Naush<br>
<br>
Thanks for this patch.<br>
<br>
On Wed, 20 Jan 2021 at 08:35, Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>> wrote:<br>
><br>
> Update the bcm2835-isp.h file with the latest version available in the<br>
> downstream Raspberryp Pi linux repo.<br>
><br>
> This change adds support for colour denoise processing, and the<br>
> following downstream kernel changes must be available:<br>
> <a href="https://github.com/raspberrypi/linux/pull/4069" rel="noreferrer" target="_blank">https://github.com/raspberrypi/linux/pull/4069</a><br>
> <a href="https://github.com/raspberrypi/linux/pull/4083" rel="noreferrer" target="_blank">https://github.com/raspberrypi/linux/pull/4083</a><br>
><br>
> The Raspberry Pi image must also be running the latest firmware,<br>
> obtained by running rpi-update.<br>
><br>
> Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> ---<br>
> include/linux/bcm2835-isp.h | 32 +++++++++++++++++++++++++++++---<br>
> 1 file changed, 29 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/include/linux/bcm2835-isp.h b/include/linux/bcm2835-isp.h<br>
> index 45abb681517e..94c3af947883 100644<br>
> --- a/include/linux/bcm2835-isp.h<br>
> +++ b/include/linux/bcm2835-isp.h<br>
> @@ -31,7 +31,8 @@<br>
> (V4L2_CID_USER_BCM2835_ISP_BASE + 0x0007)<br>
> #define V4L2_CID_USER_BCM2835_ISP_DPC \<br>
> (V4L2_CID_USER_BCM2835_ISP_BASE + 0x0008)<br>
> -<br>
> +#define V4L2_CID_USER_BCM2835_ISP_CDN \<br>
> + (V4L2_CID_USER_BCM2835_ISP_BASE + 0x0009)<br>
> /*<br>
> * All structs below are directly mapped onto the equivalent structs in<br>
> * drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h<br>
> @@ -46,7 +47,7 @@<br>
> */<br>
> struct bcm2835_isp_rational {<br>
> __s32 num;<br>
> - __s32 den;<br>
> + __u32 den;<br>
<br>
Pickier people than myself might comment that this seems unrelated,<br>
though I agree it looks sensible!<br></blockquote><div><br></div><div>In the commit message I mentioned that this is a port of the latest version of the uapi header for this very reason :-) This includes all changes upto and including the new cdn definitions. Hope folks won't find this converversal.</div><div><br></div><div>Regards,</div><div>Naush</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> };<br>
><br>
> /**<br>
> @@ -140,7 +141,7 @@ struct bcm2835_isp_black_level {<br>
> __u16 black_level_r;<br>
> __u16 black_level_g;<br>
> __u16 black_level_b;<br>
> - __u8 pad_[2]; /* Unused */<br>
> + __u8 padding[2]; /* Unused */<br>
<br>
Ditto!<br>
<br>
Apart from these small things:<br>
<br>
Reviewed-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br>
<br>
Thanks!<br>
David<br>
<br>
> };<br>
><br>
> /**<br>
> @@ -175,6 +176,31 @@ struct bcm2835_isp_gamma {<br>
> __u16 y[BCM2835_NUM_GAMMA_PTS];<br>
> };<br>
><br>
> +/**<br>
> + * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.<br>
> + *<br>
> + * @CDN_MODE_FAST: Fast (but lower quality) colour denoise<br>
> + * algorithm, typically used for video recording.<br>
> + * @CDN_HIGH_QUALITY: High quality (but slower) colour denoise<br>
> + * algorithm, typically used for stills capture.<br>
> + */<br>
> +enum bcm2835_isp_cdn_mode {<br>
> + CDN_MODE_FAST = 0,<br>
> + CDN_MODE_HIGH_QUALITY = 1,<br>
> +};<br>
> +<br>
> +/**<br>
> + * struct bcm2835_isp_cdn - Colour denoise parameters set with the<br>
> + * V4L2_CID_USER_BCM2835_ISP_CDN ctrl.<br>
> + *<br>
> + * @enabled: Enable colour denoise.<br>
> + * @cdn_mode: Colour denoise operating mode (see enum &bcm2835_isp_cdn_mode)<br>
> + */<br>
> +struct bcm2835_isp_cdn {<br>
> + __u32 enabled;<br>
> + __u32 mode;<br>
> +};<br>
> +<br>
> /**<br>
> * struct bcm2835_isp_denoise - Denoise parameters set with the<br>
> * V4L2_CID_USER_BCM2835_ISP_DENOISE ctrl.<br>
> --<br>
> 2.25.1<br>
><br>
> _______________________________________________<br>
> libcamera-devel mailing list<br>
> <a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
> <a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>