<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 22 Jan 2021 at 10:22, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi everyone<br>
<br>
This patch set removes the old Raspberry Pi logging from all our<br>
control algorithms and replaces it with libcamera logging. There is<br>
literally nothing in this patch set except for the necessary macro<br>
replacements and a few whitespace adjustments to keep the style<br>
checker happy.<br>
<br>
This is actually quite an important change because, now that we're<br>
about to publish libcamera versions of our legacy applications, it<br>
makes it much easier to get debug information from our customers.<br>
<br>
Perhaps the biggest question is whether to squish all the patches<br>
together? I've not done this yet as it's easier to squish than to<br>
un-squish, though I did roll up all the "minor" algorithms into a<br>
single commit. But I'll happily do that if it's tidier!<br>
<br>
Thanks and best regards<br>
David<br></blockquote><div><br></div><div>Very useful! For the entire series:</div><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
David Plowman (5):<br>
ipa: raspberrypi: controller: Replace Raspberry Pi debug with<br>
libcamera debug<br>
ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera<br>
debug<br>
ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug<br>
ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug<br>
ipa: raspberrypi: Remove legacy Rasberry Pi logging<br>
<br>
src/ipa/raspberrypi/controller/algorithm.hpp | 1 -<br>
src/ipa/raspberrypi/controller/controller.cpp | 29 +++---<br>
src/ipa/raspberrypi/controller/logging.hpp | 30 ------<br>
src/ipa/raspberrypi/controller/rpi/alsc.cpp | 59 ++++++------<br>
src/ipa/raspberrypi/controller/rpi/awb.cpp | 92 ++++++++++---------<br>
.../controller/rpi/black_level.cpp | 8 +-<br>
src/ipa/raspberrypi/controller/rpi/ccm.cpp | 24 +++--<br>
.../raspberrypi/controller/rpi/contrast.cpp | 15 ++-<br>
src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +-<br>
src/ipa/raspberrypi/controller/rpi/geq.cpp | 18 ++--<br>
src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 ++-<br>
src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++-<br>
src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 +++--<br>
.../raspberrypi/controller/rpi/sharpen.cpp | 8 +-<br>
14 files changed, 179 insertions(+), 160 deletions(-)<br>
delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp<br>
<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>