<div dir="ltr"><div dir="ltr">Hi David,</div><div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 8 Mar 2021 at 22:39, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi again everyone<br>
<br>
Thanks to Laurent for reviewing the previous version of this<br>
set. Here's a version 2, taking account of his comments. The<br>
differences are:<br>
<br>
1. In the first patch some stray comment lines have been deleted.<br>
<br>
2. In the second patch, files have been ordered alphabetically.<br>
<br>
3. There's a new 3rd patch, which edits the raspberrypi.mojom file so<br>
that the vblank field in the SensorConfig is more accurately named<br>
vblankDelay.<br>
<br>
Thanks and best regards<br>
<br>
David</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
David Plowman (3):<br>
ipa: raspberrypi: Make CamHelpers return the frame delay for vblanking<br>
ipa: raspberrypi: Add support for imx290/imx327 sensors<br>
ipa: raspberrypi: Rename vblank field in SensorConfig to vblankDelay<br>
<br></blockquote><div><br></div><div>For all three patches:</div><div>
Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>> </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
include/libcamera/ipa/raspberrypi.mojom | 2 +-<br>
src/ipa/raspberrypi/cam_helper.cpp | 4 +-<br>
src/ipa/raspberrypi/cam_helper.hpp | 11 +-<br>
src/ipa/raspberrypi/cam_helper_imx290.cpp | 67 +++++++<br>
src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +-<br>
src/ipa/raspberrypi/cam_helper_ov5647.cpp | 7 +-<br>
src/ipa/raspberrypi/data/imx290.json | 165 ++++++++++++++++++<br>
src/ipa/raspberrypi/data/meson.build | 1 +<br>
src/ipa/raspberrypi/meson.build | 1 +<br>
src/ipa/raspberrypi/raspberrypi.cpp | 6 +-<br>
.../pipeline/raspberrypi/raspberrypi.cpp | 2 +-<br>
11 files changed, 258 insertions(+), 15 deletions(-)<br>
create mode 100644 src/ipa/raspberrypi/cam_helper_imx290.cpp<br>
create mode 100644 src/ipa/raspberrypi/data/imx290.json<br>
<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>